Escape special characters in docs #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
jsoriano
approved these changes
Jul 29, 2021
internal/docs/exported_fields.go
Outdated
Comment on lines
74
to
75
| strings.ReplaceAll(c.name, "*", "\\*"), | ||
| strings.ReplaceAll(description, "*", "\\*"), |
There was a problem hiding this comment.
Nit. Consider using a Replacer, so we only need to keep a list of replacements.
1 task
added 2 commits
July 30, 2021 12:16
mtojek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: elastic/integrations#1366
This PR updates elastic-package to escape
* { } < >characters while rendering docs.