Skip to content

Use Go 1.16 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2021
Merged

Use Go 1.16 #455

merged 5 commits into from
Aug 2, 2021

Conversation

@mtojek
Copy link
Contributor

@mtojek mtojek commented Aug 2, 2021 •
edited
Loading

This PR modifies go.mod to use Go 1.16 to build the application.

Spotted in: #456

@mtojek mtojek self-assigned this Aug 2, 2021
@mtojek mtojek marked this pull request as draft August 2, 2021 12:49
@mtojek mtojek mentioned this pull request Aug 2, 2021
Merged
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 2, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-02T13:28:22.004+0000

  • Duration: 28 min 14 sec

  • Commit: af597cc

Test stats 🧪

Test Results
Failed 0
Passed 316
Skipped 4
Total 320

Trends 🧪

Image of Build Times

Image of Tests

@mtojek mtojek marked this pull request as ready for review August 2, 2021 13:58
@mtojek mtojek requested a review from jsoriano August 2, 2021 13:58
jsoriano
jsoriano approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Go version used in CI specified somewhere else?

@mtojek
Copy link
Contributor Author

mtojek commented Aug 2, 2021 •
edited
Loading

It uses statement in go.mod: go 1.15. That's why I bumped it to 1.16.

@mtojek mtojek merged commit e665fb2 into elastic:master Aug 2, 2021
@mtojek mtojek mentioned this pull request Aug 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mtojek mtojek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtojek @elasticmachine @jsoriano