export dashboards: add option to skip TLS verification #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
jsoriano
approved these changes
Aug 10, 2021
internal/cobraext/const.go
Outdated
| SkipPullRequestFlagName = "skip-pull-request" | ||
| SkipPullRequestFlagDescription = "skip opening a new pull request" | ||
|
|
||
| SkipTLSVerifyFlagName = "skip-tls-verify" |
There was a problem hiding this comment.
Nit. Use tls as prefix of the flag in case there are more tls flags in the future.
Suggested change
| SkipTLSVerifyFlagName = "skip-tls-verify" | |
| SkipTLSVerifyFlagName = "tls-skip-verify" |
There was a problem hiding this comment.
Brain fart on my side, you're absolutely right about this. Working on this...
added 2 commits
August 10, 2021 10:42
jsoriano
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #453
FYI @akshay-saraswat