Skip to content

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 2, 2021

Golint is discontinued, migrate to staticcheck. (see golang/go#44354 (comment)).

@jsoriano jsoriano requested a review from mtojek September 2, 2021 19:45
@jsoriano jsoriano self-assigned this Sep 2, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-03T11:58:16.752+0000

  • Duration: 25 min 3 sec

  • Commit: 41973fb

Test stats 🧪

Test Results
Failed 0
Passed 422
Skipped 5
Total 427

Trends 🧪

Image of Build Times

Image of Tests

mdelapenya
mdelapenya previously approved these changes Sep 3, 2021
@mdelapenya
Copy link
Contributor

As a follow-up improvement, have you thought about integrating pre-commit? https://pre-commit.com/hooks.html It does support staticcheck

@jsoriano
Copy link
Member Author

jsoriano commented Sep 3, 2021

/test

@jsoriano
Copy link
Member Author

jsoriano commented Sep 3, 2021

Failing test is failing in other branches too.

@jsoriano
Copy link
Member Author

jsoriano commented Sep 3, 2021

Failing test is failing in other branches too.

PR open to skip the failing test #504

@jsoriano jsoriano dismissed mdelapenya’s stale review September 3, 2021 12:00

Issues detected by staticcheck addressed since this review.

@jsoriano jsoriano requested a review from mdelapenya September 3, 2021 15:28
@jsoriano jsoriano merged commit 1b72de9 into elastic:master Sep 3, 2021
@jsoriano jsoriano deleted the staticcheck-linting branch September 3, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants