Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Sep 22, 2021

What does this PR do?

Use https://github.com/elastic/apm-pipeline-library/blob/master/vars/obltGitHubComments.txt

Why is it important?

Avoid hardcoded strings and easy to normalise the GitHub comments in all the oblt projects

You can also see in the GitHub comment that there is a specific section for some of those GitHub comments called 🤖 GitHub comments

@v1v v1v added the automation label Sep 22, 2021
@v1v v1v requested a review from a team September 22, 2021 09:04
@v1v v1v self-assigned this Sep 22, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-22T09:04:29.424+0000

  • Duration: 31 min 42 sec

  • Commit: d380339

Test stats 🧪

Test Results
Failed 0
Passed 433
Skipped 5
Total 438

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test

  • jenkins run the tests

@v1v v1v merged commit 81c66f0 into elastic:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants