Skip to content

Import external references in the right order #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Import external references in the right order #530

merged 1 commit into from
Oct 4, 2021

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 4, 2021 •
edited
Loading

External fields were imported after being used for the first time, causing some checks ie: isNumericKeyword to fail.

@marc-gr marc-gr added the bug Something isn't working label Oct 4, 2021
@marc-gr marc-gr requested a review from mtojek October 4, 2021 09:07
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 27 min 58 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

mtojek
mtojek approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid concern, thanks for opening the PR!

@marc-gr marc-gr merged commit 292a41f into elastic:master Oct 4, 2021
@marc-gr marc-gr deleted the fix-external-import-order branch October 4, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @mtojek