-
Notifications
You must be signed in to change notification settings - Fork 127
Use embedded GeoIP database #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # HOWTO: Use MaxMind's GeoIP database in tests | ||
|
|
||
| Elasticsearch provides default GeoIP databases that can be downloaded in runtime and which weights ~70 MB. This can be | ||
| a root cause of flakiness of package tests, so elastic-package embeds small samples of GeoIP databases, that can identify | ||
| accurately only few ranges of IP addresses: | ||
|
|
||
| ``` | ||
| 1.128.3.4 | ||
| 175.16.199.1 | ||
| 216.160.83.57 | ||
| 216.160.83.61 | ||
| 67.43.156.12 | ||
| 81.2.69.143 | ||
| 81.2.69.144 | ||
| 81.2.69.145 | ||
| 81.2.69.193 | ||
| 89.160.20.112 | ||
| 89.160.20.156 | ||
| 67.43.156.12 | ||
| 67.43.156.13 | ||
| 67.43.156.14 | ||
| 67.43.156.15 | ||
| 2a02:cf40:add:4002:91f2:a9b2:e09a:6fc6 | ||
| ``` | ||
|
|
||
| If you want the ingest pipeline to include a "geo" section in the event, feel free to use one of above IP addresses. | ||
| Embedded databases contain information about: cities, countries and ASNs. |
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files should be added only when using 8.x versions of the stack, otherwise we will need to regenerate all integrations targeting 7.x.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering how does it work at the moment.
If you look at the master build: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Felastic-package/detail/master/249/pipeline/ , it contains the
ingest.geoip.downloader.enabled: falseand the output is like this:In 8.0.0 (this PR) it's like this:
It would be a directory hack to make it running as we use the Docker Compose snapshot, so basically:
ingest-geoip-defaultandingest-geoip-8x. The first one would be empty. Otherwise it won't be possible without the blocker I linked in the original issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea what these log lines mean 😬
What I have seen is that in 7.x, if the downloader is disabled, then it uses a set of included databases, with the downloader it downloads a new set and uses it. In 8.0 no set of databases are included, so without databases no enrichment is done and a tag is added to indicate the problem.
Ok, if this is too hacky maybe we have to wait for #557.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try with the hack and we'll decide what to do about it.