-
Notifications
You must be signed in to change notification settings - Fork 127
Install Elastic Agent in Kubernetes cluster in compatible stack version #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| return errors.Wrap(err, "can't create Kibana client") | ||
| } | ||
|
|
||
| metadata, err := kibanaClient.InjectedMetadata() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Not sure if this injected metadata is something documented or long term supported. We could have a method to get the kibana version, ever if under the hood there can be different methods in the future to discover it. But we can also wait for this future, it may never come :)
| metadata, err := kibanaClient.InjectedMetadata() | |
| version, err := kibanaClient.Version() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea, more future oriented :) I will adjust the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes: #567
Kubernetes service deployer selects the stack version based on the running Kibana: