Refactor pipelineResource into a separate package #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
added
enhancement
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This helps the type to be reused by other packages
efd6
reviewed
Jan 5, 2022
mtojek
reviewed
Jan 10, 2022
| } | ||
|
|
||
| // FileName returns the original filename associated with the pipeline. | ||
| func (p *Resource) FileName() string { |
| ) | ||
|
|
||
| // Resource represents a pipeline resource loaded from a file | ||
| type Resource struct { |
There was a problem hiding this comment.
I'm thinking loud now, as the Resource may be too vague.
An alternative approach would be:
- create the
ingestpackage in theinternal/elasticsearchdirectory - add
pipelines.go - create the structure Pipeline.
or just move this file (with unit test) to the internal/elasticsearch directory, and rename to Pipeline. WDYT?
mtojek
approved these changes
Jan 11, 2022
efd6
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps the type to be reused by other packages in the future.
First part of refactoring #585 into smaller PRs.