-
Notifications
You must be signed in to change notification settings - Fork 127
Implement minimal pipeline to publish a package #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/test |
b25a703 to
947273c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, quite minimal pipeline at the end. Thanks for adding it!
| steps { | ||
| cleanup(source: 'build-package') | ||
| dir("${BASE_DIR}") { | ||
| packageStoragePublish('build/integrations') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd vote for moving this to a shared library, so signing and publishing in any repository is basically a one line :)
We would need to see how to pass all the parameters in case environment is not recommended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that it would be a big input map with all properties :) I'm ok with moving it there, not sure if I should do this now or later. WDYT?
I guess it's a matter of priorities: indexing & package registry implementation vs. support in apm-pipeline-library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, do it later, no need to do it now.
| withGoEnv() { | ||
| dir("${BASE_DIR}") { | ||
| sh(label: 'Install elastic-package',script: "make install") | ||
| // sh(label: 'Install elastic-package', script: 'go build github.com/elastic/elastic-package') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this here for reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as for anyone outside of the elastic-package most likely it would be the other command.
Related: #728
This PR implements the minimal pipeline required to publish a package to the Package Storage v2. I extracted the publishing part from the main Jenkinsfile and put it in a separate mini-pipeline. We can discuss if/what we should we push to the apm-pipeline-library.