Skip to content

Conversation

@mtojek
Copy link
Contributor

@mtojek mtojek commented Mar 16, 2022

Related: #728

This PR implements the minimal pipeline required to publish a package to the Package Storage v2. I extracted the publishing part from the main Jenkinsfile and put it in a separate mini-pipeline. We can discuss if/what we should we push to the apm-pipeline-library.

@mtojek mtojek self-assigned this Mar 16, 2022
@mtojek mtojek changed the title Implement minimal pipeline Implement minimal pipeline to publish a package Mar 16, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-16T15:49:05.407+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 582
Skipped 1
Total 583

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mtojek
Copy link
Contributor Author

mtojek commented Mar 16, 2022

/test

@mtojek mtojek force-pushed the implement-minimal-pipeline branch from b25a703 to 947273c Compare March 16, 2022 15:27
@mtojek mtojek marked this pull request as ready for review March 16, 2022 16:03
@mtojek mtojek requested a review from a team March 16, 2022 16:03
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, quite minimal pipeline at the end. Thanks for adding it!

steps {
cleanup(source: 'build-package')
dir("${BASE_DIR}") {
packageStoragePublish('build/integrations')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for moving this to a shared library, so signing and publishing in any repository is basically a one line :)
We would need to see how to pass all the parameters in case environment is not recommended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that it would be a big input map with all properties :) I'm ok with moving it there, not sure if I should do this now or later. WDYT?

I guess it's a matter of priorities: indexing & package registry implementation vs. support in apm-pipeline-library

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, do it later, no need to do it now.

withGoEnv() {
dir("${BASE_DIR}") {
sh(label: 'Install elastic-package',script: "make install")
// sh(label: 'Install elastic-package', script: 'go build github.com/elastic/elastic-package')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this here for reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as for anyone outside of the elastic-package most likely it would be the other command.

@mtojek mtojek merged commit f8f678d into elastic:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants