-
Notifications
You must be signed in to change notification settings - Fork 127
Compare test results using json diff #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth adding those problematic tests here?
Do you mean to add the problematic packages as test cases here? |
|
Yes, the ones that failed in the Integrations repository. |
@mtojek I have added a simple sample package that reproduces the issues found in elastic/integrations#2845. This will allow us to easily add test cases with numbers in documents. |
|
Pushed change to remove colored output and avoid issues with output in CI and so on. See this build for example: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Felastic-package/detail/PR-743/6/tests/. |
|
I guess that we should collect some feedback regarding this change as it may affect the user experience. /cc our frequent users @kaiyan-sheng @andrewkroh @P1llus @ChrsMark: |
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The more concise output makes it easier to spot the differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this change to make it easier to compare! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! :)
|
/test |
Use json diff to compare results of pipeline tests. This avoids failures caused by different format of equal numbers, as was the case in elastic/integrations#2845.
After this change two json documents are equal if their values are, independently of their format.
The biggest UX change is that this changes the diff to something like this:
The library used has more options to customize the diff format.
We could also decide to show the previous diff if this one detects differences.