Enable developer extensions #840
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
internal/fields/validate.go
Outdated
| v.Schema, err = loadFieldsFromDir(fieldsDir) | ||
| if err != nil { | ||
| return nil, errors.Wrapf(err, "can't load fields for data stream (path: %s)", dataStreamRootPath) | ||
| return nil, errors.Wrapf(err, "can't load fields for data stream (path: %s)", fieldsParentDir) |
There was a problem hiding this comment.
Nit. This message is also now about input packages, right? We may need to change this error message.
| if err != nil { | ||
| return nil, errors.Wrap(err, "can't find package root") | ||
| } | ||
| if !found { |
There was a problem hiding this comment.
Could this hide problems with malformed packages?
On what cases is it ok to not find the package root? Could you add a comment here about this?
There was a problem hiding this comment.
I added a comment, let me know what do you think.
There was a problem hiding this comment.
Ok, we can revisit this if found to be problematic at some point. Would it make sense to add a debug message here?
| if err != nil { | ||
| return nil, errors.Wrap(err, "can't find package root") | ||
| } | ||
| if !found { |
There was a problem hiding this comment.
Ok, we can revisit this if found to be problematic at some point. Would it make sense to add a debug message here?
3 participants
Meta-issue: elastic/package-spec#319
Changes:
Related:
elastic/package-spec#350