Pass policy_template name to Kibana for system tests #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
andrewkroh
force-pushed
the
bugfix/pass-policy-template-system-tests
branch
from
04cca09 to
ed264b7
Compare
🌐 Coverage report
|
andrewkroh
force-pushed
the
bugfix/pass-policy-template-system-tests
branch
from
ed264b7 to
61e6e5c
Compare
4 tasks
When calling `POST /api/fleet/package_policies` for packages that
containing multiple policy_templates, the name of the policy_template
associated to the input under test should be specified.
If the policy_template is not specified then Kibana will default to
the first policy_template which may not contain the input or may
not contain the expected package level variables for the test.
This affected testing packages like AWS.
The error that this fixes is:
Error: error running package system tests: could not complete test run:
could not add data stream config to policy: could not add package to policy;
API status code = 500; response body = {"statusCode":500,
"error":"Internal Server Error","message":"Input template not found, unable
to find input type logfile"}
Fixes elastic#899
andrewkroh
force-pushed
the
bugfix/pass-policy-template-system-tests
branch
from
61e6e5c to
bdfe548
Compare
|
/test |
jsoriano
approved these changes
Oct 4, 2022
|
@andrewkroh sorry for the late review, can you please take a look to the merge conflicts? Thanks! |
…emplate-system-tests
|
Conflicts addressed. ✅ |
jsoriano
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
POST /api/fleet/package_policiesfor packages thatcontaining multiple policy_templates, the name of the policy_template
associated to the input under test should be specified.
If the policy_template is not specified then Kibana will default to
the first policy_template which may not contain the input or may
not contain the expected package level variables for the test.
This affected testing packages like AWS.
The error that this fixes is:
Fixes #899