Skip to content

Conversation

@djptek
Copy link
Contributor

@djptek djptek commented Jul 26, 2022

Mention --version in the documentation for elastic-package stack up

Adding this because it is not clear how to set a specific version when spinning up the stack.

I put this in the description to avoid confusion with e.g.

elastic-package help version which shows the version of elastic-package

I didn't add as a flag, since this is only relevant to stack up - that would really require breaking stack down into its components, however, that remains an option. Let me know

@djptek djptek marked this pull request as draft July 26, 2022 09:03
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-27T09:10:39.623+0000

  • Duration: 28 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 771
Skipped 0
Total 771

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (32/32) 💚
Files 66.667% (78/117) 👍
Classes 62.195% (102/164) 👍
Methods 49.697% (328/660) 👍
Lines 33.198% (2940/8856) 👍
Conditionals 100.0% (0/0) 💚

@djptek djptek requested a review from mtojek July 26, 2022 11:09
@djptek djptek marked this pull request as ready for review July 26, 2022 11:10
@mtojek
Copy link
Contributor

mtojek commented Jul 26, 2022

/test

@djptek djptek marked this pull request as draft July 26, 2022 12:43
@djptek
Copy link
Contributor Author

djptek commented Jul 26, 2022

note:

elastic-package stack help generates a help message at a higher level than --version so no detail
elastic-package stack up help starts the stack, no help message
elastic-package stack up --help generates a help message with detail on --version

@djptek djptek marked this pull request as ready for review July 27, 2022 10:39
@mtojek mtojek merged commit f1c1b22 into elastic:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants