Skip to content

Conversation

@mtojek
Copy link
Contributor

@mtojek mtojek commented Jul 26, 2022

Spotted in: elastic/apm-server#8717

This PR fixes the reference to the cmd while running a CommandAction. For composing commands, like check, the sub-command actions, build, lint, format, receive a pointer to the check command instead of corresponding build/lint/format ones. As result, none of these commands can read their flags (and their default values).

I spotted this bug while trying to elastic-package check the APM package, but the tool didn't create .zip files, even though the build-zip flag should be enabled by default. Due to the bug, the command action couldn't read the default value.

@mtojek mtojek requested a review from a team July 26, 2022 11:07
@mtojek mtojek self-assigned this Jul 26, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T11:08:08.607+0000

  • Duration: 39 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 771
Skipped 0
Total 771

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (32/32) 💚
Files 66.667% (78/117) 👍
Classes 62.195% (102/164) 👍
Methods 49.697% (328/660) 👍
Lines 33.198% (2940/8856) 👍
Conditionals 100.0% (0/0) 💚

@mtojek mtojek merged commit 1f7fd68 into elastic:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants