Fix: use correct Command while running action #911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted in: elastic/apm-server#8717
This PR fixes the reference to the
cmdwhile running aCommandAction. For composing commands, likecheck, the sub-command actions,build,lint,format, receive a pointer to thecheckcommand instead of corresponding build/lint/format ones. As result, none of these commands can read their flags (and their default values).I spotted this bug while trying to
elastic-package checkthe APM package, but the tool didn't create .zip files, even though the build-zip flag should be enabled by default. Due to the bug, the command action couldn't read the default value.