Skip to content

Conversation

@mtojek
Copy link
Contributor

@mtojek mtojek commented Sep 5, 2022

This PR introduces a short HOWTO paragraph about prereleases in Package Storage v2.

@mtojek mtojek requested review from a team and joshdover September 5, 2022 10:56
@mtojek mtojek self-assigned this Sep 5, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-05T14:38:53.030+0000

  • Duration: 30 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 783
Skipped 0
Total 783

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.


Notice: if you prefer Fleet users not to pick up and install prereleases, it's recommended to be cautious with exposing new features
until [kibana#122973](https://github.com/elastic/kibana/issues/122973) is implemented. With this feature, users can decide
whether they can pick up prerelease package revisions.
Copy link
Member

@jsoriano jsoriano Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also recommend to focus more on local/internal testing before publishing prerelease packages till elastic/kibana#122973 is implemented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a sentence about the local dev environment.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (32/32) 💚
Files 66.949% (79/118)
Classes 62.424% (103/165)
Methods 49.625% (331/667)
Lines 33.296% (2986/8968)
Conditionals 100.0% (0/0) 💚

@mtojek
Copy link
Contributor Author

mtojek commented Sep 5, 2022

@v1v Another bug:

[2022-09-05T14:05:58.608Z] BucketNotFoundException: 404 gs://fleet-ci-temp-internal bucket does not exist.

@v1v
Copy link
Member

v1v commented Sep 5, 2022

I'll review it now, I recall It was created, but maybe i'm confused with a different name.

@v1v
Copy link
Member

v1v commented Sep 5, 2022

/test

@mtojek mtojek merged commit 64b8a71 into elastic:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants