EPR: enable proxy mode #957
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| COPY profiles/${PROFILE}/stack/package-registry.config.yml /package-registry/config.yml | ||
| COPY stack/development/ /packages/development | ||
|
|
||
| ENTRYPOINT ["./package-registry", "--feature-proxy-mode", "--log-level", "debug"] |
There was a problem hiding this comment.
Most of the features of package-registry have been configured in the docker-compose.yml using environment variables. What about moving settings related to logging to docker-compose file and keep the entrypoint as:
ENTRYPOINT ["./package-registry", "--feature-proxy-mode"]
Since proxy mode is going to be the default behaviour of the package-registry, it would make sense to keep it in the Dockerfile.
And then, moving the log-level parameter to the docker-compose (EPR_LOG_LEVEL?). In the docker-compose-stack.yaml should be something like:
environment:
- "EPR_LOG_LEVEL=debug"
- "EPR_ADDRESS=0.0.0.0:8080"
- "EPR_METRICS_ADDRESS=0.0.0.0:9000"
- "EPR_TLS_KEY=/etc/ssl/package-registry/key.pem"
- "EPR_TLS_CERT=/etc/ssl/package-registry/cert.pem"
I think if the parameter is set in the command line has preference over the environment variables. Moving the log level as environment variable could be changed by developers in the docker-compose without re-building the image.
| COPY profiles/${PROFILE}/stack/package-registry.config.yml /package-registry/config.yml | ||
| COPY stack/development/ /packages/development | ||
|
|
||
| ENTRYPOINT ["./package-registry", "--feature-proxy-mode", "--log-level", "debug"] |
There was a problem hiding this comment.
Just one dash ?
| ENTRYPOINT ["./package-registry", "--feature-proxy-mode", "--log-level", "debug"] | |
| ENTRYPOINT ["./package-registry", "-feature-proxy-mode", "-log-level", "debug"] |
|
/test |
1 similar comment
|
/test |
| COPY profiles/${PROFILE}/stack/package-registry.config.yml /package-registry/config.yml | ||
| COPY stack/development/ /packages/development | ||
|
|
||
| ENTRYPOINT ["./package-registry", "-feature-proxy-mode"] |
There was a problem hiding this comment.
It should be also possible to use environment variables to configure this: EPR_FEATURE_PROXY_MODE=true. This may be better than setting the entrypoint, as we are already using environment variables to disable validation.
| - /packages/development | ||
| - /packages/production | ||
| - /packages/staging | ||
| - /packages/snapshot |
| // PackageRegistryBaseImage is the base Docker image of the Elastic Package Registry. | ||
| const PackageRegistryBaseImage = "docker.elastic.co/package-registry/distribution:snapshot" | ||
| // commit SHA of enabled proxy mode (technical preview feature) | ||
| const PackageRegistryBaseImage = "docker.elastic.co/package-registry/package-registry:14455fcb7e415d6b4aed48e00d2289718f056162" |
There was a problem hiding this comment.
Do you want to wait to have a released version with this?
There was a problem hiding this comment.
Yes, as I'm afraid that we may need to add more fixes, and going with the standard release will slow it down. I will replace it with a proper release after some time.
4 participants
Issue: elastic/package-registry#770
This PR enables the proxy mode feature in the elastic-package stack.