Fix HTTPS connection when host is an IP address #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic/elasticsearch-py#1958
While it looks like it might be possible to use an IP address in a certificate, I've never seen it used and it's explicitly forbidden for SNI (RFC 3546, Section 3.1). Additionally,
server_hostnameis not set in urllib3 when the host is an IP, which raises an exception in the ssl standard module.The main majority of the new code comes from urllib3. I could have used
urllib3.util.ssl_.is_ip_addressdirectly but thought that was rude!