Ignore properties found after "values" in ESQL response #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
approved these changes
Oct 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 20, 2025
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
l-trotta
added a commit
that referenced
this pull request
Oct 20, 2025
l-trotta
added a commit
that referenced
this pull request
Oct 20, 2025
l-trotta
added a commit
that referenced
this pull request
Oct 20, 2025
l-trotta
added a commit
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ES|QL query is run with
"profile": true, some additional properties are added after"values"in the response. The methodEsqlAdapterBase.readFooter()was expecting the end of the response object, causing a parsing error.This PR makes it more lenient: all remaining properties are ignored until the end of the object.