Improved the body BC break description in request/response for 8.x documentation #2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
previously approved these changes
Jan 4, 2024
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Except one word
docs/changelog.asciidoc
Outdated
|
|
||
| This could be a rather big breaking change, so a double solution could be used during the 8.x lifecycle. (accepting body keys without them being wrapped in the body as well as the current solution). | ||
|
|
||
| To convert code from 7.x, you just need to remove the `body` parameter in all the endpoints request. |
Member
There was a problem hiding this comment.
Can you please eliminate the word just? https://developers.google.com/style/word-list#just
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation about the
bodybreaking changes in 8.x.