Skip to content

Conversation

@jeffvestal
Copy link
Contributor

Notebook for upcoming blog Re-ranking with an Elasticsearch hosted cross-encoder from HuggingFace

@gitnotebooks
Copy link

gitnotebooks bot commented Oct 28, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/346

@jeffvestal jeffvestal requested a review from joemcelroy October 28, 2024 20:21
Copy link
Contributor

@carlyrichmond carlyrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one minor typo (warking rather than warning) in the notebook. Otherwise it looks reasonable.

Can you also add it to the listing in the README?

https://github.com/elastic/elasticsearch-labs/blob/main/README.md

…king-elasticsearch-hosted.ipynb


fix typo

Co-authored-by: Carly Richmond <74931905+carlyrichmond@users.noreply.github.com>
@jeffvestal
Copy link
Contributor Author

@carlyrichmond What section should I add the notebook? We don't have a specific "blog notebooks"

@carlyrichmond
Copy link
Contributor

@carlyrichmond What section should I add the notebook? We don't have a specific "blog notebooks"

Ah yes you're right, my mistake. That's fine then. It's just the typo that needs to be corrected, and the post should be good to merge.

Just let me know when that's been actioned and I can merge.

@jeffvestal
Copy link
Contributor Author

I pushed a small update that fixed the index name in the query.
I'm good to have it merged

Copy link
Contributor

@carlyrichmond carlyrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlyrichmond carlyrichmond merged commit 213d5af into main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants