-
Notifications
You must be signed in to change notification settings - Fork 253
addding notebook for re-ranking-elasticsearch-hosted blog #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/346 |
carlyrichmond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one minor typo (warking rather than warning) in the notebook. Otherwise it looks reasonable.
Can you also add it to the listing in the README?
https://github.com/elastic/elasticsearch-labs/blob/main/README.md
supporting-blog-content/re-ranking-elasticsearch-hosted/re-ranking-elasticsearch-hosted.ipynb
Outdated
Show resolved
Hide resolved
…king-elasticsearch-hosted.ipynb fix typo Co-authored-by: Carly Richmond <74931905+carlyrichmond@users.noreply.github.com>
|
@carlyrichmond What section should I add the notebook? We don't have a specific "blog notebooks" |
Ah yes you're right, my mistake. That's fine then. It's just the typo that needs to be corrected, and the post should be good to merge. Just let me know when that's been actioned and I can merge. |
|
I pushed a small update that fixed the index name in the query. |
supporting-blog-content/re-ranking-elasticsearch-hosted/re-ranking-elasticsearch-hosted.ipynb
Outdated
Show resolved
Hide resolved
carlyrichmond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Notebook for upcoming blog Re-ranking with an Elasticsearch hosted cross-encoder from HuggingFace