Skip to content

Conversation

@kritinv
Copy link
Contributor

@kritinv kritinv commented Feb 22, 2025

This notebook is a tutorial on evaluating and picking the best hyperparameters for a RAG system using an Elasticsearch retriever, with DeepEval. It follows the contents of the corresponding blog.

@gitnotebooks
Copy link

gitnotebooks bot commented Feb 22, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/403

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 22, 2025

💚 CLA has been signed

@xeraa
Copy link

xeraa commented Feb 23, 2025

@kritinv please sign the CLA (https://www.elastic.co/contributor-agreement) with the email you used in Git / GitHub for making the PR.

@kritinv
Copy link
Contributor Author

kritinv commented Feb 28, 2025

Hey @xeraa, I believe the CLA has been signed. Thanks!

@xeraa
Copy link

xeraa commented Mar 4, 2025

Great, the CLA is done (and the comment updated — I was briefly confused by the timeline).

Since I'm also traveling this week, @JessicaGarson can you please take a look at the failures of the PR (might be something more cosmetic) and merge it. Then we can also get the blog post published.

@JessicaGarson
Copy link
Contributor

Thanks, @kritinv.

Sine the pre-commit checks are failing. You may want to try running the checks this way:

python -m venv .venv
.venv/bin/pip install -qqq -r requirements-dev.txt
.venv/bin/pre-commit install

You can find more infomation in our contributing guide. If you have issues after that, try moving the notebook to the supporting-blog-content folder, since this notebook corresponds to a blog post. This folder is more flexible when it comes to formatting checks.

@kritinv
Copy link
Contributor Author

kritinv commented Mar 11, 2025

I think this has been fixed! @JessicaGarson

@JessicaGarson
Copy link
Contributor

Hi @kritinv,

It still looks like the checks are failing here - the easiest way to resolve this is moving this post from notebooks/evaluation/optimizing-retrieval-with-deepeval.ipynb to notebooks/supporting-blog-content/optimizing-retrieval-with-deepeval.ipynb

@kritinv
Copy link
Contributor Author

kritinv commented Mar 12, 2025

@JessicaGarson moved it!

@JessicaGarson JessicaGarson merged commit ffb6011 into elastic:main Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants