Skip to content

chatbot-rag-app: removes unnecessary parts of Docker build #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

chatbot-rag-app: removes unnecessary parts of Docker build #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83253bd
chatbot-rag-app: removes docker workaround for OTEL_SDK_DISABLED
codefromthecrypt Mar 4, 2025
ad69506
update k8s
codefromthecrypt Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions example-apps/chatbot-rag-app/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ EXPOSE 4000
# Default to disabling instrumentation, can be overridden to false in
# docker invocations to reenable.
ENV OTEL_SDK_DISABLED=true
ENTRYPOINT [ "opentelemetry-instrument" ]

# TODO remove custom entrypoint when EDOT Python >0.7.0 is released.
RUN echo 'if [ "${OTEL_SDK_DISABLED:-true}" == "false" ]; \
then \
opentelemetry-instrument $@; \
else \
exec $@; \
fi' > entrypoint.sh
ENTRYPOINT [ "bash", "-eu", "./entrypoint.sh" ]
CMD [ "python", "api/app.py" ]
2 changes: 1 addition & 1 deletion example-apps/chatbot-rag-app/k8s-manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
initContainers:
- name: create-index
image: &image ghcr.io/elastic/elasticsearch-labs/chatbot-rag-app:latest
command: &command [ "bash", "-eu", "./entrypoint.sh" ] # match image
command: &command [ "opentelemetry-instrument" ] # match image
args: [ "flask", "create-index" ]
# This recreates your configmap based on your .env file:
# kubectl create configmap chatbot-rag-app-env --from-env-file=.env
Expand Down
2 changes: 1 addition & 1 deletion example-apps/chatbot-rag-app/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,4 +531,4 @@ opentelemetry-instrumentation-sqlalchemy==0.51b0
opentelemetry-instrumentation-system-metrics==0.51b0
opentelemetry-instrumentation-tortoiseorm==0.51b0
opentelemetry-instrumentation-urllib3==0.51b0
elastic-opentelemetry-instrumentation-openai==0.6.0
elastic-opentelemetry-instrumentation-openai==0.6.1