Skip to content

Conversation

@leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Mar 12, 2025

Flagged by @ppf2 in Slack: https://elastic.slack.com/archives/C07CY6V62H2/p1741637324838029

Making internal links in jump list just be plaintext because these links have weird behavior depending on where you're viewing the notebook:

  • in GitHub preview they link somewhere wrong
  • locally in VSCode they work as expected
  • in Colab they don't do anything

Flagged by @ppf2 in Slack: https://elastic.slack.com/archives/C07CY6V62H2/p1741637324838029

Making internal links in jump list just be plaintext because these links have weird behavior depending on where you're viewing the notebook: 

- :in preview they link somewhere wrong 
-   locally in VSCode they work as expected 
-  in Colab they don't do anything
@leemthompo leemthompo self-assigned this Mar 12, 2025
@gitnotebooks
Copy link

gitnotebooks bot commented Mar 12, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/420

@leemthompo leemthompo requested a review from a team March 12, 2025 09:59
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@pquentin pquentin merged commit 54839a4 into main Mar 18, 2025
5 checks passed
@pquentin pquentin deleted the leemthompo-patch-1 branch March 18, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants