Add ServerError.TryCreate() method

Author: russcam

src/Elasticsearch.Net/Responses/ServerException/ServerError.cs

@@ -18,9 +18,24 @@ public ServerError(Error error, int? statusCode)
 		public Error Error { get; }
 		public int Status { get; }
 
+		public static bool TryCreate(Stream stream, out ServerError serverError)
+		{
+			try
+			{
+				serverError = Create(stream);
+				return true;
+			}
+			catch
+			{
+				serverError = null;
+				return false;
+			}
+		}
+
 		public static ServerError Create(Stream stream) =>
 			LowLevelRequestResponseSerializer.Instance.Deserialize<ServerError>(stream);
 
+		// TODO: make token default parameter in 7.x
 		public static Task<ServerError> CreateAsync(Stream stream, CancellationToken token) =>
 			LowLevelRequestResponseSerializer.Instance.DeserializeAsync<ServerError>(stream, token);
 

src/Elasticsearch.Net/Responses/Special/BytesResponse.cs

@@ -12,17 +12,11 @@ public BytesResponse() { }
 		public bool TryGetServerError(out ServerError serverError)
 		{
 			serverError = null;
-			if (this.Body == null || this.Body.Length == 0) return false;
-			try
-			{
-				using(var stream = new MemoryStream(this.Body))
-					serverError = ServerError.Create(stream);
-				return true;
-			}
-			catch
-			{
+			if (this.Body == null || this.Body.Length == 0)
 				return false;
-			}
+
+			using(var stream = new MemoryStream(this.Body))
+				return ServerError.TryCreate(stream, out serverError);
 		}
 
 		protected override bool TryGetServerErrorReason(out string reason)

src/Elasticsearch.Net/Responses/Special/StringResponse.cs

@@ -12,17 +12,11 @@ public StringResponse() { }
 		public bool TryGetServerError(out ServerError serverError)
 		{
 			serverError = null;
-			if (string.IsNullOrEmpty(this.Body)) return false;
-			try
-			{
-				using(var stream = new MemoryStream(Encoding.UTF8.GetBytes(this.Body)))
-					serverError = ServerError.Create(stream);
-				return true;
-			}
-			catch (Exception)
-			{
+			if (string.IsNullOrEmpty(this.Body))
 				return false;
-			}
+
+			using(var stream = new MemoryStream(Encoding.UTF8.GetBytes(this.Body)))
+				return ServerError.TryCreate(stream, out serverError);
 		}
 
 		protected override bool TryGetServerErrorReason(out string reason)