Fix #646 deleteby query should not throw if no default index is set

Author: Mpdreamz

src/Elasticsearch.Net/Connection/InMemoryConnection.cs

@@ -10,7 +10,11 @@ namespace Elasticsearch.Net.Connection
 	public class InMemoryConnection : HttpConnection
 	{
 		private byte[] _fixedResultBytes = Encoding.UTF8.GetBytes("{ \"USING NEST IN MEMORY CONNECTION\"  : null }");
-
+		public InMemoryConnection()
+			: base(new ConnectionConfiguration())
+		{
+			
+		}
 		public InMemoryConnection(IConnectionConfigurationValues settings)
 			: base(settings)
 		{

src/Nest/ElasticClient.cs

@@ -45,7 +45,7 @@ public ElasticClient(
 			this.Connection = connection ?? new HttpConnection(settings);
 
 			this.Serializer = serializer ?? new NestSerializer(this._connectionSettings);
-			var stringifier = new NestStringifier(settings);
+			var stringifier = new NestStringifier(this._connectionSettings);
 			this.Raw = new ElasticsearchClient(
 				this._connectionSettings, 
 				this.Connection, 

src/Nest/ExposedInternals/ElasticInferrer.cs

@@ -25,6 +25,7 @@ public string DefaultIndex
 				return (this._connectionSettings == null) ? string.Empty : this._connectionSettings.DefaultIndex;
 			}
 		}
+
 		public ElasticInferrer(IConnectionSettingsValues connectionSettings)
 		{
 			this._connectionSettings = connectionSettings;

src/Nest/Resolvers/IndexNameResolver.cs

@@ -14,7 +14,7 @@ public class IndexNameResolver
 
 		public IndexNameResolver(IConnectionSettingsValues connectionSettings)
 		{
-			connectionSettings.ThrowIfNull("hasDefaultIndices");
+			connectionSettings.ThrowIfNull("connectionSettings");
 			this._connectionSettings = connectionSettings;
 		}
 

src/Nest/Resolvers/TypeNameResolver.cs

@@ -13,7 +13,7 @@ public class TypeNameResolver
 
 		public TypeNameResolver(IConnectionSettingsValues connectionSettings)
 		{
-			connectionSettings.ThrowIfNull("hasDefaultIndices");
+			connectionSettings.ThrowIfNull("connectionSettings");
 			this._connectionSettings = connectionSettings;
 			this._propertyNameResolver = new PropertyNameResolver(this._connectionSettings);
 		}

src/Tests/Nest.Tests.Unit/BigBadUrlUnitTests.cs

@@ -74,6 +74,7 @@ public void TestAllTheUrls()
 			Do("DELETE", "/customindex/doc/_query", c => c.DeleteByQuery<Doc>(q => q.Index("customindex").MatchAll()));
 			Do("DELETE", "/_all/doc/_query", c => c.DeleteByQuery<Doc>(q => q.AllIndices().MatchAll()));
 			Do("DELETE", "/mydefaultindex/_query", c => c.DeleteByQuery<Doc>(q => q.AllTypes().MatchAll()));
+			Do("DELETE", "/custom-index/_query", c => c.DeleteByQuery<Doc>(q => q.Index("custom-index").AllTypes().MatchAll()));
 			Do("DELETE", "/mydefaultindex", c => c.DeleteIndex(i => i.Index<Doc>()));
 			Do("DELETE", "/a%2Cb", c => c.DeleteIndex(i => i.Indices("a", "b")));
 			Do("POST", "/_bulk", c => c.DeleteMany(Enumerable.Range(0, 10).Select(i => new Doc { Id = i.ToString() })));

src/Tests/Nest.Tests.Unit/Reproduce/Reproduce646Tests.cs

@@ -0,0 +1,43 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
+using Elasticsearch.Net.Connection;
+using NUnit.Framework;
+
+namespace Nest.Tests.Unit.Reproduce
+{
+	/// <summary>
+	/// tests to reproduce reported errors
+	/// </summary>
+	[TestFixture]
+	public class Reproduce646Tests : BaseJsonTests
+	{
+		/// <summary>
+		/// https://github.com/Mpdreamz/NEST/issues/646
+		/// </summary>
+		[Test]
+		public void Issue646()
+		{
+			var client = new ElasticClient(connection: new InMemoryConnection());
+			Assert.DoesNotThrow(()=>
+			{
+				var result = _client.DeleteByQuery<object>(dq => dq
+					.Index("my-custom-index")
+					.AllTypes()
+					.Query(q => q
+						.Filtered(descriptor => descriptor
+							.Filter(filterDescriptor => filterDescriptor
+								.Not(descriptor1 => descriptor1
+									.Term("indexProcessId", "1")
+								)
+							)
+						)
+					)
+				);	
+			});
+			
+		}
+
+	}
+}