Skip to content

Conversation

russcam
Copy link
Contributor

@russcam russcam commented May 9, 2016

Closes #1986

requires backporting to 2.x branch (dependent on answer to elastic/elasticsearch#17031 (comment))

@gmarz
Copy link
Contributor

gmarz commented May 11, 2016

LGTM 👍. My only comment is that we possibly rename ReindexRethrottle() to just Rethrottle() to make it more obvious that it also applies to update by query.

@russcam
Copy link
Contributor Author

russcam commented May 11, 2016

@gmarz Agreed. Will update the PR. Thanks for reviewing 👍

naming aligns with the fact that the endpoint can be used to rethrottle other ongoing tasks such as update by query as well as reindex operations
@russcam russcam merged commit 02e8626 into master May 27, 2016
@gmarz gmarz deleted the feature/reindex-rethrottle branch July 7, 2016 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants