Allow 404s for Get and Delete requests #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Nov 3, 2016
russcam
force-pushed
the
fix/2.x-allow404s
branch
2 times, most recently
from
463fedb to
d16ebcf
Compare
Update Rest Api Specs to v2.4.1 Closes #2306
|
Added integration tests for delete and get on non-existent documents. |
|
Guys, we wanted to let you know that this breaks backwards compatibility. We just lost a lot of time due to this enhancement... Can these kind of changes be kept for major upgrades? |
|
I'm sorry to hear @rdehuys we strive not to break bwc but I can see this being a big functional change. should we
Neither is pretty but I'd hate for others to lose time here too. Cc @elastic/microsoft |
|
We upgraded our part of the code, so all is fine now. Our test suite luckily failed so nothing went broken to production. So, option 2 is fine for us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Rest Api Specs to v2.4.1
Closes #2306