Mark IsValid obsolete for get and delete responses to warn about the … #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
reviewed
Mar 22, 2017
| [Obsolete(@"WARNING: IsValid behavior has changed to align with 1.x and 5.x onwards. | ||
| It now returns true for 404 responses (document not found), where previously it returned | ||
| false. Please use .Found to check whether the document was actually found.")] | ||
| public override bool IsValid => (this.ApiCall?.Success ?? fa[Obsolse) && (this.ServerError == null); |
| using System.Linq.Expressions; | ||
| using Newtonsoft.Json; | ||
| using System.Linq; | ||
| using System.ServiceModel.ComIntegration; |
There was a problem hiding this comment.
Don't think this directive is needed
…behavioral change in #2367
gmarz
force-pushed
the
fix/isvalid-warnings
branch
from
7769db1 to
109a5d2
Compare
|
@forloop good call, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…behavioral change in #2367