add support for the char_group tokenizer #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses to do full blown endpoint testing (cherry picked from commit d6f1ae5)
(cherry picked from commit f5f0c437871589b1fb90b6c4c6f09f0dfc296d7e)
(cherry picked from commit c74ed51e2c30804ffc1d50f95a17893a93bfa6ea)
(cherry picked from commit f2da9f51b43b188cc1b2d09f616fbf87ca268344)
(cherry picked from commit 7ecbee5435df02810ede7f07985e7bb13f66b6f3)
…ch implements the bulk of the setup and tests (cherry picked from commit 8a6e99493a4174a87cc8680609afd0c482cf10d7)
russcam
suggested changes
Oct 13, 2018
| { | ||
| /// <summary> | ||
| /// The maximum token length. If a token is seen that exceeds this length then it is discarded. Defaults to 255. | ||
| /// </summary> |
There was a problem hiding this comment.
I think the documentation should be
A list containing a list of characters to tokenize the string on. Whenever a character from this list is encountered, a
new token is started. This accepts either single characters like eg. -, or character groups: whitespace, letter, digit,
punctuation, symbol.
| /// The maximum token length. If a token is seen that exceeds this length then it is discarded. Defaults to 255. | ||
| /// </summary> | ||
| [JsonProperty("tokenize_on_chars")] | ||
| IEnumerable<string> TokenizeOnCharacters { get; set; } |
There was a problem hiding this comment.
specialized type that takes a union of enum and char? string is no doubt easier to use.
russcam
approved these changes
Oct 17, 2018
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
(cherry picked from commit 9ab4384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending #3424