Skip to content

fix #3505 daterange default DateTime should not serialize #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2019

Conversation

Mpdreamz
Copy link
Member

Pending the merge of 6.5 branch and all related PR's to that target branch.

@Mpdreamz
Copy link
Member Author

The build is failing on travis because we need to be explicit about langversion.

Something already fixed on 6.5, will retarget this PR against 6.5.

@Mpdreamz Mpdreamz changed the base branch from 6.x to 6.5 January 17, 2019 09:23
* Return overloads that do not take format on Field in 6.x, removing them was a bwc breaking change

* Remove ambiguity on Field constructor and Field static methods on Infer

* Fixed overload of Field on static infer still being nullable, and chain methods And on Field

* string overload on field constructor needed fixing too
@Mpdreamz Mpdreamz force-pushed the fix/date-range-date-min branch from e7dfb68 to 87a250b Compare January 24, 2019 13:16
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a minor comment

@Mpdreamz Mpdreamz merged commit 9040a0b into 6.5 Jan 25, 2019
@Mpdreamz Mpdreamz deleted the fix/date-range-date-min branch January 25, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants