load yaml tests from same branch as client #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
load-yaml-tests-from-branch
branch
from
99dd070 to
f788efc
Compare
miguelgrinberg
force-pushed
the
load-yaml-tests-from-branch
branch
from
f788efc to
7c41234
Compare
miguelgrinberg
commented
Nov 19, 2025
| if pytest_test_name.startswith(prefix): | ||
| pytest_test_name = pytest_test_name[len(prefix) :] | ||
| pytest_param_id = "%s[%d]" % (pytest_test_name, test_number) | ||
| pytest_param_id = "[%s]%s[%d]" % (branch, pytest_test_name, test_number) |
Contributor
Author
There was a problem hiding this comment.
We do not have to keep this forever, but initially this will be confirmation of which of all the possible branches was used in the end.
miguelgrinberg
force-pushed
the
load-yaml-tests-from-branch
branch
from
7c41234 to
4ad28b4
Compare
Member
|
This is failing due to: However, that test is part of |
miguelgrinberg
force-pushed
the
load-yaml-tests-from-branch
branch
from
9e91d83 to
f102c82
Compare
pquentin
approved these changes
Nov 20, 2025
|
|
||
| from elasticsearch import ApiError, ElasticsearchWarning, RequestError | ||
| from elasticsearch._sync.client.utils import _base64_auth_header | ||
| from elasticsearch._version import __versionstr__ |
Member
There was a problem hiding this comment.
For what it's worth, importlib.metadata.version is the modern way to do that. Not asking you to change it though!
Contributor
Author
There was a problem hiding this comment.
I trust that we are less likely to break this in the future than the Python org.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
* load yaml tests from same branch as client * restore checks for failed or skipped tests (cherry picked from commit b1ad37a)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
* load yaml tests from same branch as client * restore checks for failed or skipped tests (cherry picked from commit b1ad37a)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
* load yaml tests from same branch as client * restore checks for failed or skipped tests (cherry picked from commit b1ad37a)
This was referenced Nov 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
* load yaml tests from same branch as client * restore checks for failed or skipped tests (cherry picked from commit b1ad37a)
miguelgrinberg
added a commit
that referenced
this pull request
Nov 20, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Nov 20, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Nov 20, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to load the YAML tests for CI from the same branch as the client, instead of always loading
main. When running a PR build, the branch is not going to exist in the YAML tests repository, so in that case we fallback tomainas before.