Skip to content

Conversation

@marciw
Copy link
Contributor

@marciw marciw commented Nov 20, 2025

I was on PTO when #3158 flew by, so offering some suggestions in this PR.

Preview

docs/reference/index.md

Summary of changes

  • Changed values of from_ and size to integers rather than strings
  • Various editorial improvements for clarity, readability, and consistency with Elastic style

(Does not include any changes to the Compatibility section because I have an in-progress PR for that section)

@github-actions
Copy link

@marciw marciw requested a review from Copilot November 20, 2025 20:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation for clarity and consistency with Elastic style guidelines. The changes focus on editorial refinements to the reference documentation, including correcting parameter types and improving language precision.

Key changes:

  • Changed from_ and size parameters from string to integer values in code examples
  • Improved documentation language for clarity and consistency with Elastic style
  • Standardized terminology (e.g., "ES|QL Query Builder" → "ES|QL query builder")

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/reference/index.md Updated example code to use integer values for pagination parameters; improved documentation descriptions for clarity and style consistency
docs/reference/esql-query-builder.md Standardized title capitalization from "ES|QL Query Builder" to "ES|QL query builder"
docs/reference/dsl_tutorials.md Updated internal reference to match new standardized terminology

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

TIL about [](foo.md).

Copy link
Contributor

@ketkee-aryamane ketkee-aryamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes!

@miguelgrinberg miguelgrinberg merged commit 1a0dae5 into elastic:main Nov 21, 2025
17 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2025
* [int]s not strings

* Various cleanup

(cherry picked from commit 1a0dae5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants