-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DOCS] Edit recent updates for clarity and Elastic style #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for clarity and consistency with Elastic style guidelines. The changes focus on editorial refinements to the reference documentation, including correcting parameter types and improving language precision.
Key changes:
- Changed
from_andsizeparameters from string to integer values in code examples - Improved documentation language for clarity and consistency with Elastic style
- Standardized terminology (e.g., "ES|QL Query Builder" → "ES|QL query builder")
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/reference/index.md | Updated example code to use integer values for pagination parameters; improved documentation descriptions for clarity and style consistency |
| docs/reference/esql-query-builder.md | Standardized title capitalization from "ES|QL Query Builder" to "ES|QL query builder" |
| docs/reference/dsl_tutorials.md | Updated internal reference to match new standardized terminology |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pquentin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
TIL about [](foo.md).
ketkee-aryamane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fixes!
* [int]s not strings * Various cleanup (cherry picked from commit 1a0dae5)
I was on PTO when #3158 flew by, so offering some suggestions in this PR.
Preview
docs/reference/index.md
Summary of changes
from_andsizeto integers rather than strings(Does not include any changes to the Compatibility section because I have an in-progress PR for that section)