unable to get records if the table primary key is not id

[teknofire]

I'm unable to fetch records from my legacy database when the primary_key has been changed.

It looks like the default method for fetching the records when using ActiveRecord is hardcoded to with "id" as the primary key field, and will fail to fetch records even if the models primary_key attribute has been set.

Example:

class Site < ActiveRecord::Base
    self.primary_key = 'siteid'
end

response = Site.search('Test')
response.records.first
# Fails with the following error -> ERROR:  column sites.id does not exist
# should be trying to use sites.siteid

[karmi]

Yes, indeed -- embarrasing error. I'll change the ActiveRecord adapter to use klass.primary_id in that code.

[kengsrengtang]

Hi tecknofire
I can't reproduce that bug. Even I try to change the primary_key.
Can please help send a complete scenario?
thank!

[teknofire]

Sure here is a repo with a simple script based on the examples in the elasticsearch-model README

if you want something that is using rails I can pretty easily upload an example for that as well

[karmi]

@teknofire I think there's no need to do that -- it's quite clear from the code that the gem uses where(id: ...), so hardcoding the id as the primary key...

[karmi]

There's #11 with the fix (klass.primary_key instead of id), waiting for @ayamomiji to get back with me with some info.

[karmi]

This has slipped me -- closed in 72f0e76, thanks for the report!

[karmi]

Argh, left this open, sorry for the spam, closed in 72f0e76.