Skip to content

Conversation

@meesterdude
Copy link
Contributor

This is to address the change needed for #135, which is to address #131.

@lleger @johvet does this work for you?

@lleger
Copy link

lleger commented Jul 19, 2014

Works for me 👍

@meesterdude
Copy link
Contributor Author

what does this PR need to be pushed through? I'm not sure whats up with travis, but this does work on my dev machine and the tests pass.

@karmi
Copy link
Contributor

karmi commented Jul 28, 2014

@meesterdude I'll have a look at it this week. Was held up with something else.

@karmi
Copy link
Contributor

karmi commented Jul 28, 2014

@meesterdude It seems like you haven't signed the CLA, by the way, could you do it, please?

@meesterdude
Copy link
Contributor Author

@karmi actually I did that first thing; I have the echosign doc in my inbox, do I need to forward it somewhere?

@karmi
Copy link
Contributor

karmi commented Jul 28, 2014

@meesterdude Great, no need to forward, should be in our systems then!

karmi pushed a commit that referenced this pull request Jul 28, 2014
@karmi karmi closed this in f676a15 Jul 28, 2014
@karmi
Copy link
Contributor

karmi commented Jul 28, 2014

So, finally merged & pushed it, thanks!

@meesterdude
Copy link
Contributor Author

was this correctly merged? GH reports unmerged commits; and i'm getting undefined methodoffset' for #Elasticsearch::Model::Response::Results:0x007fcd532da7f8`

@karmi
Copy link
Contributor

karmi commented Sep 15, 2014

What unmerged commits? I've rebased your commits and added your changes as d9777fd and f676a15, to master branch.

@meesterdude
Copy link
Contributor Author

hrm nevermind, looks like the code is there, not sure why GH is reporting unmerged commits then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants