Model#save should persist updated_at timestamp #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
ryansch
force-pushed
the
persistence-model-updated-at
branch
from
b25bac9 to
5a93f49
Compare
There was a problem hiding this comment.
I could revert this. I feel more strongly about ActiveSupport::TimeWithZone as in #395. The rest of this PR is more important.
|
@ryansch Thanks, merged! |
|
@ryansch And sorry it took so long, please ping me next time, I'm a bit overloaded at times and need a nudge. |
|
No problem! Thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, a persistence model will not actually save the updated_at timestamp to elasticsearch.
I've moved the change to the updated_at timestamp before the call to
gateway#save. Additionally, I've changed thecreated_atandupdated_attimestamps to be aTimeto more closely match how Rails deals with timestamps and to match how the code in store.rb is treating them.