Skip to content

Conversation

@swallez
Copy link
Contributor

@swallez swallez commented Nov 18, 2021

Refactor and fix the Multi{Search|Get|TemplateSearch} APIs:

  • fix some definitions that were not correct
  • introduce unions to distiguish the header and body parts of ndjson requests
  • reuse types between APIs when possible.

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one note

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, just a nit.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swallez swallez merged commit 5213646 into elastic:main Nov 22, 2021
@swallez swallez deleted the fix-multi-apis branch November 22, 2021 10:42
swallez added a commit that referenced this pull request Nov 22, 2021
@swallez swallez mentioned this pull request Nov 22, 2021
swallez added a commit that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants