Unify ScoreMode, ChildScoreMode & move sort to common types #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Move sort to common types
swallez
changed the title
delvedor
requested changes
Nov 23, 2021
Member
delvedor
left a comment
delvedor
left a comment
There was a problem hiding this comment.
Overall LGTM, but I think the sort definition should go in the global _types folder instead of _types/query_dsl, as it's used outside of the context of a query.
swallez
added a commit
that referenced
this pull request
Nov 23, 2021
swallez
added a commit
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some duplicate enums, and move sort-related types to commons where they're already used.