Skip to content

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Jun 8, 2023

elastic/elasticsearch#93946 added position time series metric. This PR updates TimeSeriesMetricType to include position.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me! will let @swallez give a final +1 and merge (but I hope to get much more familiar with the spec soon.)

Copy link
Contributor

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit fe23fb0 into elastic:main Jun 13, 2023
swallez pushed a commit that referenced this pull request Jul 5, 2023
* add posotion to TimeSeriesMetricType

* output changes
nreese added a commit to elastic/kibana that referenced this pull request Jul 11, 2023
…e series metric fields (#161689)

`position` is valid response for field_caps `time_series_metric` field.
It has been added to elasticsearch-specification,
elastic/elasticsearch-specification#2143, (but
is not yet in Kibana). This PR updates _fields_for_wildcard schema to
include 'position' as valid value

### Test instructions
* clone https://github.com/thomasneirynck/faketracks
* cd into `faketracks`
* run `npm install`
* run `node ./generate_tracks.js --isTimeSeries`
* In Kibana, create `tracks` data view
* Verify _fields_for_wildcard endpoint does not return 500 error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants