Validated watcher.stats Response #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvedor
approved these changes
Mar 29, 2021
Member
delvedor
left a comment
delvedor
left a comment
There was a problem hiding this comment.
Very likely the yaml test is using "true" instead of true. It should be fixed there.
l-trotta
added a commit
that referenced
this pull request
Feb 8, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 8, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 8, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727) * making node info path optional (issue #242) * making node info discover seed_host optional (issue #242) * changed description for update by query (issue #315) * adding custom options to index settings similarity (issue #299) * initial_master_nodes from string to string[] (issue #242) * correct contrib * correct node info discover class (issue #242)
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727) * making node info path optional (issue #242) * making node info discover seed_host optional (issue #242) * changed description for update by query (issue #315) * initial_master_nodes from string to string[] (issue #242) * correct node info discover class (issue #242) * generate and contrib
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727) * making node info path optional (issue #242) * making node info discover seed_host optional (issue #242) * changed description for update by query (issue #315) * adding custom options to index settings similarity (issue #299) * initial_master_nodes from string to string[] (issue #242) * correct contrib * correct node info discover class (issue #242)
l-trotta
added a commit
that referenced
this pull request
Feb 19, 2024
* Batch from java issues (#2412) * added 'remove_binary' to AttachmentProcessor (issue #727) * making node info path optional (issue #242) * making node info discover seed_host optional (issue #242) * changed description for update by query (issue #315) * adding custom options to index settings similarity (issue #299) * initial_master_nodes from string to string[] (issue #242) * correct contrib * correct node info discover class (issue #242) * contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled.
@delvedor, I wanted to validated the request as well but ran into a type casting issue:
and
emit_stacktracesis of typebooleaninWatcherStatsRequest.ts🤷