Wrap ts-morph errors to provide helpful error #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
approved these changes
Jun 24, 2024
Member
|
Thanks for taking care of this! |
kderusso
pushed a commit
that referenced
this pull request
Jun 25, 2024
* wrap ts-morph errors to provide helpful error * improve after lint
kderusso
added a commit
that referenced
this pull request
Jun 26, 2024
…n for text_expansion and weighted_tokens queries (#2642) * Add sparse_vector query to client specification * Fix error and update contrib * PR feedback * Populate endpoint deprecation from request definition (#2640) * Update specification output * Wrap ts-morph errors to provide helpful error (#2644) * wrap ts-morph errors to provide helpful error * improve after lint * Bump braces from 3.0.2 to 3.0.3 in /typescript-generator (#2645) Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Query Rules] Update Query Rules API for 8.15 (#2639) * Mark existing query rules APIs as GA * Add individual CRUD API calls * Linting * PR feedback * PR feedback * Update specification output * Update output * Update output * Fix variant annotations for SparseVectorQuery --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Florian Bernd <git@flobernd.de> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to 5828dc9 we wrap the propagated error such that the message become:
failed to parse SparseVectorQuery, reason: cannot determine type of query, got: String