Added include_named_queries_score to search #2729
Conversation
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Nope, no problems from JS. 👍 |
|
@pquentin added it to multisearch, thank you! |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Should we also add the performance caveat from the docs?
Typically, this adds a small overhead to a request. However, using computationally expensive named queries on a large number of hits may add significant overhead.
Also, the server_default false annotation is missing.
(Sorry for missing that earlier.)
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
@flobernd @Anaethelion let me know when the generators are ready so that we can merge this |
|
@l-trotta My generator is adjusted. |
|
@l-trotta all good for me. |
* added include_named_queries_score to search * correctly mapping matched_queries * also added to multisearch * added more description + default (cherry picked from commit f2a90e8)
* added include_named_queries_score to search * correctly mapping matched_queries * also added to multisearch * added more description + default (cherry picked from commit f2a90e8) Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
Added in 8.8,
include_named_queries_scoreadds the score to the result of named query.In practice, it changes the type of matched_queries in Hit from
string[]tostring[] | Dictionary<string,double>, because the server will return a different data structure depending on the value ofinclude_named_queries_scorein the request.After discussing this, we decided that for now strongly typed clients (java, go, .net) won't support it, but we're still adding this to the spec for completeness and for other clients that might be able to support it.
@Anaethelion, @flobernd before merging this we need to exclude
include_named_queries_scorefrom the available query parameters and ignore the secondary type ofmatched_queries.@JoshMock does this cause any problem for javascript?
fixes #2405