-
Couldn't load subscription status.
- Fork 116
Set parameter nodes instead of node_id on task.list #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is a great catch. Unfortunately none of the Elasticsearch YAML tests that we use for validation set nodes, which is why we missed it. However it was part of validation errors:
elasticsearch-specification/output/schema/validation-errors.json
Lines 1181 to 1186 in 36dbbd9
| "tasks.list": { | |
| "request": [ | |
| "Request: query parameter 'node_id' does not exist in the json spec", | |
| "Request: query parameter 'master_timeout' does not exist in the json spec", | |
| "Request: missing json spec query parameter 'nodes'" | |
| ], |
In addition to your fix, I also switched the type from string[] to NodeIds (which is string | string[]):
- typed clients could have a specific type for this
- this allows for a comma-separated string too, which is the format Elasticsearch accepts (lists in query parameters are comma-separated by clients before sending)
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit d7200dc)
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit d7200dc)
|
Thank you for your contribution, your change is now available in elasticsearch-py 8.16.0 (and all the other clients that use the specification). Note that elasticsearch-py 8.16.0 added warnings for tech preview/beta APIs and the Task management API is part of those. The release notes explain how to disable the warning. |
Closes #3112, closes #3114
Use parameter
nodesinstead ofnode_idontask.list.