Skip to content

Conversation

pquentin
Copy link
Member

(One test is still failing.)

This comment was marked as outdated.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_settings Missing test Missing test
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 37/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
watcher.update_settings Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@pquentin
Copy link
Member Author

Closing as those changes are based on out-of-date NEST tests.

@pquentin pquentin closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant