Skip to content

Conversation

@swallez
Copy link
Contributor

@swallez swallez commented Dec 12, 2024

This PR fixes a few issues in the specification validation code. Every commit fixes a different issue:

  • fix validation of generic parameters in type aliases
  • adding the void and binary builtin types
  • allow union types to have generic parameters

@pquentin pquentin merged commit 9dd5b47 into main Dec 13, 2024
10 checks passed
@pquentin pquentin deleted the fix-validation-bugs branch December 13, 2024 07:34
@github-actions
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3295-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9dd5b4760e80bba78839a3845a4ee682fb92efd8
# Push it to GitHub
git push --set-upstream origin backport-3295-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3295-to-8.x.

@github-actions
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3295-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9dd5b4760e80bba78839a3845a4ee682fb92efd8
# Push it to GitHub
git push --set-upstream origin backport-3295-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3295-to-8.17.

pquentin pushed a commit to pquentin/elasticsearch-specification that referenced this pull request Dec 13, 2024
* Fix open generics definition in type alias verification

* Add void builtin type

* A tagged union can have generic parameters

* Add binary builtin type

* Fix lint

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 9dd5b47)

# Conflicts:
#	output/schema/validation-errors.json
@pquentin
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

@pquentin
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

pquentin pushed a commit to pquentin/elasticsearch-specification that referenced this pull request Dec 13, 2024
* Fix open generics definition in type alias verification

* Add void builtin type

* A tagged union can have generic parameters

* Add binary builtin type

* Fix lint

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 9dd5b47)

# Conflicts:
#	output/schema/validation-errors.json
pquentin pushed a commit that referenced this pull request Dec 13, 2024
* Fix open generics definition in type alias verification

* Add void builtin type

* A tagged union can have generic parameters

* Add binary builtin type

* Fix lint

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 9dd5b47)

# Conflicts:
#	output/schema/validation-errors.json
pquentin pushed a commit that referenced this pull request Dec 13, 2024
* Fix open generics definition in type alias verification

* Add void builtin type

* A tagged union can have generic parameters

* Add binary builtin type

* Fix lint

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 9dd5b47)

# Conflicts:
#	output/schema/validation-errors.json
@pquentin
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x
8.17

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Dec 13, 2024
* Fix open generics definition in type alias verification

* Add void builtin type

* A tagged union can have generic parameters

* Add binary builtin type

* Fix lint

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 9dd5b47)

# Conflicts:
#	output/schema/validation-errors.json

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
pquentin added a commit that referenced this pull request Dec 13, 2024
* Fix open generics definition in type alias verification

* Add void builtin type

* A tagged union can have generic parameters

* Add binary builtin type

* Fix lint

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit 9dd5b47)

# Conflicts:
#	output/schema/validation-errors.json

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants