Edit migration reindexing summaries #3573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
masseyke
reviewed
Jan 22, 2025
masseyke
reviewed
Jan 22, 2025
specification/migrate/cancel_reindex/MigrateCancelReindexRequest.ts
Outdated
Show resolved
Hide resolved
masseyke
reviewed
Jan 22, 2025
specification/migrate/get_reindex_status/MigrateGetReindexStatusRequest.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
leemthompo
approved these changes
Jan 23, 2025
Contributor
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
(cherry picked from commit a72afb8)
lcawl
added a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR edits the operation summaries for the new APIs that appear in https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-migration
That first line needs to be short and sweet and start with a verb to align with all the other titles that appear in the left-hand navigation. There's some more guidance in https://github.com/elastic/elasticsearch-specification/blob/main/docs/doc-comments-guide.md with more to come soon.
NOTE: I have not drafted descriptions for all the request body and response body properties, but those should eventually be added for clarity and completeness too.