Skip to content

Conversation

@pquentin
Copy link
Member

It’s important for Python and can be a fallback in cases where new providers are missing. Statically-typed clients are expected to exclude this endpoint.

I used https://github.com/elastic/elasticsearch-specification/tree/16c8bd383b6caa644ab64a57e989bb1d75b8b458/specification/inference as a reference, removing the examples that are now spread to provider-specific APIs.

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.chat_completion_unified Missing test Missing test
inference.completion Missing test Missing test
inference.delete Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference Missing test Missing test
inference.put_alibabacloud Missing test Missing test
inference.put_amazonbedrock Missing test Missing test
inference.put_anthropic Missing test Missing test
inference.put_azureaistudio Missing test Missing test
inference.put_azureopenai Missing test Missing test
inference.put_cohere Missing test Missing test
inference.put_elasticsearch Missing test Missing test
inference.put_elser Missing test Missing test
inference.put_googleaistudio Missing test Missing test
inference.put_googlevertexai Missing test Missing test
inference.put_hugging_face Missing test Missing test
inference.put_jinaai Missing test Missing test
inference.put_mistral Missing test Missing test
inference.put_openai Missing test Missing test
inference.put_voyageai Missing test Missing test
inference.put_watsonx Missing test Missing test
inference.put Missing test Missing test
inference.rerank Missing test Missing test
inference.sparse_embedding Missing test Missing test
inference.stream_completion Missing test Missing test
inference.text_embedding Missing test Missing test
inference.update Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.chat_completion_unified Missing test Missing test
inference.completion Missing test Missing test
inference.delete Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference Missing test Missing test
inference.put_alibabacloud Missing test Missing test
inference.put_amazonbedrock Missing test Missing test
inference.put_anthropic Missing test Missing test
inference.put_azureaistudio Missing test Missing test
inference.put_azureopenai Missing test Missing test
inference.put_cohere Missing test Missing test
inference.put_elasticsearch Missing test Missing test
inference.put_elser Missing test Missing test
inference.put_googleaistudio Missing test Missing test
inference.put_googlevertexai Missing test Missing test
inference.put_hugging_face Missing test Missing test
inference.put_jinaai Missing test Missing test
inference.put_mistral Missing test Missing test
inference.put_openai Missing test Missing test
inference.put_voyageai Missing test Missing test
inference.put_watsonx Missing test Missing test
inference.put Missing test Missing test
inference.rerank Missing test Missing test
inference.sparse_embedding Missing test Missing test
inference.stream_completion Missing test Missing test
inference.text_embedding Missing test Missing test
inference.update Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit d1072a9 into main Apr 11, 2025
8 checks passed
@pquentin pquentin deleted the add-inference.inference branch April 11, 2025 12:59
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
* Add back inference.inference API

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.

* Mention service-specific documentation

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit d1072a9)
@github-actions
Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4256-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d1072a9314368e66cfb32c04432e52bbfd9a4554
# Push it to GitHub
git push --set-upstream origin backport-4256-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4256-to-8.18.

github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
* Add back inference.inference API

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.

* Mention service-specific documentation

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit d1072a9)
picandocodigo pushed a commit that referenced this pull request Apr 11, 2025
* Add back inference.inference API

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.

* Mention service-specific documentation

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit d1072a9)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
picandocodigo pushed a commit that referenced this pull request Apr 11, 2025
* Add back inference.inference API

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.

* Mention service-specific documentation

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit d1072a9)
l-trotta pushed a commit that referenced this pull request Apr 11, 2025
* Add back inference.inference API

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.

* Mention service-specific documentation

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit d1072a9)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
picandocodigo added a commit that referenced this pull request Apr 11, 2025
* Add back inference.inference API (#4256)

* Add back inference.inference API

It’s important for Python and can be a fallback in cases where new providers
are missing. Statically-typed clients are expected to exclude this endpoint.

* Mention service-specific documentation

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
(cherry picked from commit d1072a9)

* openapi regen

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Co-authored-by: Laura Trotta <laura.trotta@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants