Skip to content

[DOCS] Add link to stored fields example #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[DOCS] Add link to stored fields example #4576

wants to merge 6 commits into from

Conversation

@marciw
Copy link
Contributor

@marciw marciw commented Jun 13, 2025 •
edited
Loading

Related to elastic/docs-projects#302 and elastic/elasticsearch#129380

✅ requisite example page already merged elastic/elasticsearch#129380

  • Add example link to stored_fields parameter description
  • Fix unrelated typos

@marciw marciw mentioned this pull request Jun 13, 2025
Merged
@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
get 🟢 299/299 296/296

You can validate this API yourself by using the make validate target.

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
get 🟢 299/299 296/296

You can validate this API yourself by using the make validate target.

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
get 🟢 299/299 296/296

You can validate this API yourself by using the make validate target.

@marciw marciw changed the title WIP [DOCS] Add link to stored fields example [DOCS] Add link to stored fields example Jun 16, 2025
@marciw marciw marked this pull request as ready for review June 16, 2025 14:45
@marciw marciw requested review from leemthompo and szabosteve June 16, 2025 14:45
szabosteve
szabosteve reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one suggestion.

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
get 🟢 299/299 296/296

You can validate this API yourself by using the make validate target.

2 similar comments
@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
get 🟢 299/299 296/296

You can validate this API yourself by using the make validate target.

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
get 🟢 299/299 296/296

You can validate this API yourself by using the make validate target.

@marciw marciw requested a review from szabosteve June 17, 2025 17:57
@marciw
Copy link
Contributor Author

marciw commented Jun 17, 2025

I left one suggestion.

@szabosteve Thanks! fixed and ready for your re-review 🙏

szabosteve
szabosteve approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, LGTM!

@marciw
Copy link
Contributor Author

marciw commented Jun 20, 2025 •
edited
Loading

Closing because that's easier and faster than resolving some dizzying conflicts 😵

redoing in #4640

@marciw marciw closed this Jun 20, 2025
@marciw marciw mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szabosteve szabosteve szabosteve approved these changes

@leemthompo leemthompo Awaiting requested review from leemthompo

Assignees

No one assigned

Labels

backport 9.0 documentation specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marciw @szabosteve