-
Notifications
You must be signed in to change notification settings - Fork 115
Minor changes to the Inference API docs #5452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
import { RequestChatCompletion } from '@inference/_types/CommonTypes' | ||
/** | ||
* Perform chat completion inference | ||
* Perform chat completion inference on the service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every other API description ends "on the service"
summary: Completion task | ||
description: Run `POST _inference/completion/openai_chat_completions` to perform a completion on the example question. | ||
method_request: 'POST _inference/completion/openai_chat_completions' | ||
description: Run `POST _inference/completion/openai_completions` to perform a completion on the example question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is for completion not chat_completions
|
||
/** | ||
* Perform completion inference on the service | ||
* Get responses for completion tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API had no desciption
"model_id": "rerank-english-v3.0", | ||
"api_key": "{{COHERE_API_KEY}}" | ||
}, | ||
"chunking_settings": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rerankers don't have chunking_settings
*/ | ||
input: string | Array<string> | ||
input: Array<string> | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding undocumented parameters
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5452-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccc753392ccbdcd3e4e1bb6ae210abd3cc1fa86c
# Push it to GitHub
git push --set-upstream origin backport-5452-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
Document rerank parameters and fix broken rerank example (cherry picked from commit ccc7533)
Document rerank parameters and fix broken rerank example (cherry picked from commit ccc7533)
No description provided.