Skip to content

Conversation

davidkyle
Copy link
Member

No description provided.

import { RequestChatCompletion } from '@inference/_types/CommonTypes'
/**
* Perform chat completion inference
* Perform chat completion inference on the service
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every other API description ends "on the service"

summary: Completion task
description: Run `POST _inference/completion/openai_chat_completions` to perform a completion on the example question.
method_request: 'POST _inference/completion/openai_chat_completions'
description: Run `POST _inference/completion/openai_completions` to perform a completion on the example question.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is for completion not chat_completions


/**
* Perform completion inference on the service
* Get responses for completion tasks.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API had no desciption

"model_id": "rerank-english-v3.0",
"api_key": "{{COHERE_API_KEY}}"
},
"chunking_settings": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerankers don't have chunking_settings

*/
input: string | Array<string>
input: Array<string>
/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding undocumented parameters

@davidkyle davidkyle requested a review from kosabogi October 9, 2025 10:13
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@davidkyle davidkyle merged commit ccc7533 into main Oct 16, 2025
13 of 14 checks passed
@davidkyle davidkyle deleted the inference-docs-tidy branch October 16, 2025 09:25
Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5452-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ccc753392ccbdcd3e4e1bb6ae210abd3cc1fa86c
# Push it to GitHub
git push --set-upstream origin backport-5452-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5452-to-9.0.

github-actions bot pushed a commit that referenced this pull request Oct 16, 2025
Document rerank parameters and fix broken rerank example

(cherry picked from commit ccc7533)
github-actions bot pushed a commit that referenced this pull request Oct 16, 2025
Document rerank parameters and fix broken rerank example

(cherry picked from commit ccc7533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants