Skip to content

Adding visit_percentage for the new DiskBBQ #5495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

Adding visit_percentage for the new DiskBBQ #5495

merged 3 commits into from
Oct 23, 2025

Conversation

@john-wagster
Copy link
Contributor

Add visit_percentage option added by elastic/elasticsearch#133753

@john-wagster john-wagster added specification skip-backport This pull request should not be backported labels Oct 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025 •
edited
Loading

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
get 🟢 317/317 → 321/321 314/314 → 318/318
index 🟢 1440/1440 → 1445/1445 1442/1442 → 1447/1447
indices.create 🔴 1373/1397 → 1378/1402 1397/1397 → 1402/1402
indices.get_mapping 🔴 198/198 → 202/202 187/198 → 191/202
search 🔴 2584/2611 → 2588/2612 2611/2611 → 2612/2612

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin requested review from flobernd and l-trotta October 15, 2025 15:40
@john-wagster
Copy link
Contributor Author

@flobernd @l-trotta just wanted to make sure ya'll had seen this. Let me know if you need anything additional from me here.

flobernd
flobernd approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙂

@flobernd flobernd added backport 9.2 and removed skip-backport This pull request should not be backported labels Oct 23, 2025
@john-wagster john-wagster merged commit 9fc82b0 into main Oct 23, 2025
11 checks passed
@john-wagster john-wagster deleted the visit_percentage_diskbbq branch October 23, 2025 14:01
github-actions bot pushed a commit that referenced this pull request Oct 23, 2025
@john-wagster @github-actions
Adding visit_percentage for the new DiskBBQ (#5495)
c8b473f 
(cherry picked from commit 9fc82b0)
@github-actions github-actions bot mentioned this pull request Oct 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flobernd flobernd flobernd approved these changes

@l-trotta l-trotta l-trotta approved these changes

Assignees

No one assigned

Labels

backport 9.2 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@john-wagster @flobernd @l-trotta